From 544aa2be55041db1252b9857ff0a159fd9240913 Mon Sep 17 00:00:00 2001
From: Jonathan Michalon <jonathan@michalon.eu>
Date: Fri, 17 May 2019 16:06:52 +0200
Subject: [PATCH] Cleanup 3 forgotten/easy FIXMEs

---
 clients/bot/src/main.vala                |  1 -
 libovcc/src/ovcc-tile-set.vala           | 47 ++++--------------------
 libovccclient/src/ovccclient-server.vala |  1 -
 3 files changed, 7 insertions(+), 42 deletions(-)

diff --git a/clients/bot/src/main.vala b/clients/bot/src/main.vala
index a2a505f..c362a3a 100644
--- a/clients/bot/src/main.vala
+++ b/clients/bot/src/main.vala
@@ -103,7 +103,6 @@ public class Bot : OVCCClient.Client
             case 3: npos.x--; break; /* left */
           }
           for (var j = 0; j < 4; j++) {
-            /* FIXME: this should probably be asynchronous... */
             if (player.place_tile (npos)) {
               debug ("Placed tile ID %u at %d %d angle %u", tile.id,
                      npos.x, npos.y, tile.rotation);
diff --git a/libovcc/src/ovcc-tile-set.vala b/libovcc/src/ovcc-tile-set.vala
index 4328340..893d18d 100644
--- a/libovcc/src/ovcc-tile-set.vala
+++ b/libovcc/src/ovcc-tile-set.vala
@@ -40,50 +40,17 @@ namespace OVCC
     }
   }
   
-  /* FIXME: update the doc */
   /**
-   * This module manages Tile Sets. Tile Sets are list of tiles and the number of
-   * them in the set.
-   * Tile Sets works together with tiles definitions to provide a set of tiles.
+   * This module manages tile sets which are a list of tiles and the amount of
+   * each of them in the set.
+   * TileSet works together with {@link Tile} to provide a set of tiles.
    * 
-   * Tile Sets are represented by #OVCCTileSet objects.
-   * 
-   * A Tile Set is created with ovcc_tileset_new() and freed using
-   * ovcc_tileset_unref(). They can be loaded from XML definitions with
-   * ovcc_tileset_load();
-   * Adding a tile to a Tile Set is done using ovcc_tileset_add(),
-   * removing one is done using ovcc_tileset_remove(), and removing all tiles from
+   * TileSets can be loaded from XML definitions with load() or
+   * from memory with load_from_string();
+   * Adding a tile to a Tile Set is done using add(),
+   * removing one is done using remove(), and removing all tiles from
    * a set is done using ovcc_tileset_clear().
    * 
-   * =Simple example showing the load of a Tile Set from an URI=
-   * 
-   * {{{
-   * #include <glib.h>
-   * #include <gio/gio.h>
-   * #include "tileset.h"
-   * 
-   * OVCCTileSet *
-   * load_our_tileset (const gchar  *uri,
-   *                   OVCCTilesDef *available_tiles)
-   * {
-   *   OVCCTileSet *set;
-   *   GFile       *file;
-   *   GError      *err = NULL;
-   *   
-   *   file = g_file_new_for_uri (uri);
-   *   set = ovcc_tileset_new ();
-   *   if (! ovcc_tileset_load (set, available_tiles, file, &err)) {
-   *     g_critical ("Failed to load Tile Set: %s", err->message);
-   *     g_error_free (err);
-   *     // Return NULL if the tile set cannot be loaded
-   *     ovcc_tileset_unref (set), set = NULL;
-   *   }
-   *   g_object_unref (file);
-   *   
-   *   return set;
-   * }
-   * }}}
-   * 
    * =Example of a tileset XML file=
    * 
    * {{{
diff --git a/libovccclient/src/ovccclient-server.vala b/libovccclient/src/ovccclient-server.vala
index 9ef9e70..c34aca3 100644
--- a/libovccclient/src/ovccclient-server.vala
+++ b/libovccclient/src/ovccclient-server.vala
@@ -464,7 +464,6 @@ namespace OVCCClient
       throws ServerError, IOError
       requires (connection != null)
     {
-      /* FIXME load right tileset and do something with stack... */
       TilesDef tiles = new TilesDef ();
       TileSet  tileset = new TileSet ();
 
-- 
GitLab